fix: propagate NEXT_PUBLIC_HELICONE_JAWN_SERVICE from docker-compose into env.js#5613
Open
shouryamaanjain wants to merge 1 commit intoHelicone:mainfrom
Open
fix: propagate NEXT_PUBLIC_HELICONE_JAWN_SERVICE from docker-compose into env.js#5613shouryamaanjain wants to merge 1 commit intoHelicone:mainfrom
shouryamaanjain wants to merge 1 commit intoHelicone:mainfrom
Conversation
…into env.js The supervisord environment directive was re-declaring env vars like NEXT_PUBLIC_HELICONE_JAWN_SERVICE and BETTER_AUTH_SECRET using %(ENV_...)s interpolation. This could override docker-compose values with Dockerfile defaults, preventing user-configured URLs from reaching the frontend. Fix: - Remove %(ENV_...)s re-declarations from supervisord.conf for both web and jawn programs — these vars are already set in the Dockerfile and are automatically inherited by child processes - Add docker-entrypoint.sh that generates __ENV.js from the container's actual NEXT_PUBLIC_* env vars before supervisord starts Closes Helicone#5551
|
@shouryamaanjain is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%(ENV_...)svariable re-declarations fromsupervisord.conffor both the web and jawn programs — these vars (NEXT_PUBLIC_HELICONE_JAWN_SERVICE,BETTER_AUTH_SECRET,S3_*) are already set asENVdefaults in the Dockerfile and are automatically inherited by supervisord child processesdocker-entrypoint.shthat generates__ENV.jsfrom allNEXT_PUBLIC_*container env vars before supervisord starts, as defense-in-depthRoot cause
The supervisord
environmentdirective for the web program was re-declaringNEXT_PUBLIC_HELICONE_JAWN_SERVICEusing%(ENV_...)sinterpolation. This overrode the value inherited from the Docker container environment, preventing docker-composeenvironmentoverrides from reaching the Next.js process. OtherNEXT_PUBLIC_*vars (likeNEXT_PUBLIC_APP_URL) worked correctly because they were NOT re-declared in the supervisord directive — they were simply inherited from the container env.Files changed
supervisord.conf%(ENV_...)svars from web and jawn environment directivesDockerfile__ENV.jsbefore services startdocker-entrypoint.shNEXT_PUBLIC_*env vars and writespublic/__ENV.jsTest plan
docker build -t helicone-test .NEXT_PUBLIC_HELICONE_JAWN_SERVICE:curl http://localhost:3000/__ENV.jscontainshttps://custom-jawn.example.comhttp://localhost:8585Closes #5551